Replace GetOption with GetOption1
#6849
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetOption1() has been available since R-2.13, and GetOption() has been ignoring its second argument for a long time, so there's no portability cost.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6849 +/- ##
==========================================
- Coverage 98.60% 98.59% -0.02%
==========================================
Files 79 79
Lines 14657 14661 +4
==========================================
+ Hits 14453 14455 +2
- Misses 204 206 +2 ☔ View full report in Codecov by Sentry. |
|
Generated via commit fe15955 Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
approved these changes
Mar 4, 2025
MichaelChirico
pushed a commit
that referenced
this pull request
Mar 10, 2025
GetOption1() has been available since R-2.13, and GetOption() has been ignoring its second argument for a long time, so there's no portability cost.
aitap
added a commit
that referenced
this pull request
Oct 26, 2025
Use the API replacement for the non-API entry point. See #6849 for the context.
aitap
added a commit
that referenced
this pull request
Nov 3, 2025
Use the API replacement for the non-API entry point. See #6849 for the context.
ben-schwen
pushed a commit
that referenced
this pull request
Nov 3, 2025
Use the API replacement for the non-API entry point. See #6849 for the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
r87874we get:GetOption1()has been available since R-2.13, andGetOption()has been ignoring its second argument for a long time, so there's no portability cost.See also: #6180